-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont convert squeeze/unsqueeze to reshape when fusing mlir #3533
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3533 +/- ##
========================================
Coverage 92.17% 92.17%
========================================
Files 512 512
Lines 21387 21391 +4
========================================
+ Hits 19714 19718 +4
Misses 1673 1673 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
Unsqueeze/squeeze/lazy_reshape perserve the layout whereas reshape doesnt. The mlir_op uses this to compute the output shape which could be different after we fuse with mlir. Instead, just convert them to reshape when we are converting to mlir.